From 97e7038d6fbe058a0dd764acaf9b80bb3515425c Mon Sep 17 00:00:00 2001 From: Mattia Iavarone Date: Thu, 4 Jul 2019 09:50:37 -0500 Subject: [PATCH] Remove comments --- .../cameraview/engine/CameraIntegration2Test.java | 7 ------- .../com/otaliastudios/cameraview/engine/Camera2Engine.java | 7 +++++-- demo/src/main/res/layout/activity_camera.xml | 2 +- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/cameraview/src/androidTest/java/com/otaliastudios/cameraview/engine/CameraIntegration2Test.java b/cameraview/src/androidTest/java/com/otaliastudios/cameraview/engine/CameraIntegration2Test.java index ad020597..74c5432b 100644 --- a/cameraview/src/androidTest/java/com/otaliastudios/cameraview/engine/CameraIntegration2Test.java +++ b/cameraview/src/androidTest/java/com/otaliastudios/cameraview/engine/CameraIntegration2Test.java @@ -9,15 +9,8 @@ import androidx.annotation.NonNull; import androidx.test.ext.junit.runners.AndroidJUnit4; import androidx.test.filters.LargeTest; -/** - * These tests work great on real devices, and are the only way to test actual CameraEngine - * implementation - we really need to open the camera device. - * Unfortunately they fail unreliably on emulated devices, due to some bug with the - * emulated camera controller. Waiting for it to be fixed. - */ @RunWith(AndroidJUnit4.class) @LargeTest -// @Ignore public class CameraIntegration2Test extends CameraIntegrationTest { @NonNull diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/engine/Camera2Engine.java b/cameraview/src/main/java/com/otaliastudios/cameraview/engine/Camera2Engine.java index 15af22a9..0417577d 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/engine/Camera2Engine.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/engine/Camera2Engine.java @@ -65,8 +65,11 @@ import java.util.concurrent.Callable; import java.util.concurrent.ExecutionException; import java.util.concurrent.atomic.AtomicBoolean; -// TODO zoom -// TODO exposure correction +import androidx.annotation.NonNull; +import androidx.annotation.Nullable; +import androidx.annotation.RequiresApi; +import androidx.annotation.WorkerThread; + @RequiresApi(Build.VERSION_CODES.LOLLIPOP) public class Camera2Engine extends CameraEngine implements ImageReader.OnImageAvailableListener { diff --git a/demo/src/main/res/layout/activity_camera.xml b/demo/src/main/res/layout/activity_camera.xml index 03b195b7..b0a360ad 100644 --- a/demo/src/main/res/layout/activity_camera.xml +++ b/demo/src/main/res/layout/activity_camera.xml @@ -17,7 +17,7 @@ android:layout_marginBottom="88dp" android:keepScreenOn="true" app:cameraExperimental="true" - app:cameraEngine="camera2" + app:cameraEngine="camera1" app:cameraPreview="glSurface" app:cameraPlaySounds="true" app:cameraGrid="off"