chore: linter violations in test files for multiple linters

.golangci.yml

@@ -60,9 +60,15 @@ issues:
     - G502
     - G505
   exclude-rules:
-    - path: browser/browser\.go
+    - path: _test\.go
       linters:
-        - 'unused'
+        - gocyclo
+        - errcheck
+        - dupl
+        - gosec
+        - unparam
+        - staticcheck
+        - paralleltest
   max-issues-per-linter: 0
   max-same-issues: 0
 

browser.go

@@ -39,7 +39,7 @@ func (c *chromium) AllBrowsingData() ([]BrowserData, error) {
 	return nil, nil
 }
 
-func (f *firefox) BrowsingData(items []browserDataType) (BrowserData, error) {
+func (f *firefox) BrowsingData(_ []browserDataType) (BrowserData, error) {
 	return nil, nil
 }
 
@@ -68,19 +68,17 @@ func (b browser) Type() browserType {
 	}
 }
 
-var (
+var browsers = map[browser]Browser{
-	browsers = map[browser]Browser{
+	Chrome: &chromium{
-		Chrome: &chromium{
+		name:          Chrome,
-			name:          Chrome,
+		storage:       chromeStorageName,
-			storage:       chromeStorageName,
+		profilePath:   chromeProfilePath,
-			profilePath:   chromeProfilePath,
+		supportedData: []browserDataType{TypePassword},
-			supportedData: []browserDataType{TypePassword},
+	},
-		},
+	Firefox: &firefox{
-		Firefox: &firefox{
+		name:        "",
-			name:        "",
+		storage:     "",
-			storage:     "",
+		profilePath: "",
-			profilePath: "",
+	},
-		},
+	Yandex: &chromium{},
-		Yandex: &chromium{},
+}
-	}
-)

chromium.go

@@ -33,10 +33,7 @@ func (c *chromium) Init() error {
 	if err := c.initProfile(); err != nil {
 		return fmt.Errorf("profile path '%s' does not exist %w", c.profilePath, ErrBrowserNotExists)
 	}
-	if err := c.initMasterKey(); err != nil {
+	return c.initMasterKey()
-		return err
-	}
-	return nil
 }
 
 func (c *chromium) initBrowserData() error {
@@ -94,9 +91,7 @@ func (c *chromium) findAllProfiles() ([]string, error) {
 }
 
 func (c *chromium) initMasterKey() error {
-	var (
+	var stdout, stderr bytes.Buffer
-		stdout, stderr bytes.Buffer
-	)
 	args := []string{"find-generic-password", "-wa", strings.TrimSpace(c.storage)}
 	cmd := exec.Command("security", args...) //nolint:gosec
 	cmd.Stdout = &stdout

chromium_test.go

@@ -4,8 +4,7 @@ import (
 	"testing"
 )
 
-func TestChromium_Init(t *testing.T) {
+func TestChromium_Init(_ *testing.T) {
-
 }
 
 func BenchmarkChromium_Init(b *testing.B) {

consts.go

@@ -17,9 +17,7 @@ const (
 	arcStorageName        = "Arc"
 )
 
-var (
+var homeDir, _ = os.UserHomeDir()
-	homeDir, _ = os.UserHomeDir()
-)
 
 var (
 	chromeProfilePath     = homeDir + "/Library/Application Support/Google/Chrome/Default/"