add try catch to catch exceptions when takePicture fails (#1024)

* add try catch to catch exceptions when takePicture fails, to give the user a better experience than an app crash

* do not log errors, as they are alreayd logged by the camera engine, and do not put try catch around DNG captures

Co-authored-by: Mattia Iavarone <mat.iavarone@gmail.com>

cameraview/src/main/java/com/otaliastudios/cameraview/picture/Full1PictureRecorder.java

@@ -1,10 +1,12 @@
 package com.otaliastudios.cameraview.picture;
 
 import android.hardware.Camera;
+import android.util.Log;
 
 import androidx.annotation.NonNull;
 import androidx.exifinterface.media.ExifInterface;
 
+import com.otaliastudios.cameraview.CameraException;
 import com.otaliastudios.cameraview.PictureResult;
 import com.otaliastudios.cameraview.engine.Camera1Engine;
 import com.otaliastudios.cameraview.engine.offset.Reference;
@@ -44,6 +46,7 @@ public class Full1PictureRecorder extends FullPictureRecorder {
         // or takePicture can hang and leave the camera in a bad state.
         mCamera.setPreviewCallbackWithBuffer(null);
         mEngine.getFrameManager().release();
+        try {
             mCamera.takePicture(
                     new Camera.ShutterCallback() {
                         @Override
@@ -95,6 +98,10 @@ public class Full1PictureRecorder extends FullPictureRecorder {
                     }
             );
             LOG.i("take() returned.");
+        } catch (Exception e) {
+            mError = e;
+            dispatchResult();
+        }
     }
 
     @Override

cameraview/src/main/java/com/otaliastudios/cameraview/picture/Full2PictureRecorder.java

@@ -8,6 +8,7 @@ import android.hardware.camera2.TotalCaptureResult;
 import android.media.Image;
 import android.media.ImageReader;
 import android.os.Build;
+import android.util.Log;
 
 import com.otaliastudios.cameraview.PictureResult;
 import com.otaliastudios.cameraview.controls.PictureFormat;
@@ -86,7 +87,13 @@ public class Full2PictureRecorder extends FullPictureRecorder
             public void onCaptureCompleted(@NonNull ActionHolder holder,
                                            @NonNull CaptureRequest request,
                                            @NonNull TotalCaptureResult result) {
+                try {
                     super.onCaptureCompleted(holder, request, result);
+                } catch (Exception e) {
+                    mError = e;
+                    dispatchResult();
+                }
+
                 if (mResult.format == PictureFormat.DNG) {
                     mDngCreator = new DngCreator(holder.getCharacteristics(this), result);
                     mDngCreator.setOrientation(ExifHelper.getExifOrientation(mResult.rotation));